Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate spend from spark to EX-address in Qt #1448

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Automate spend from spark to EX-address in Qt #1448

merged 3 commits into from
Jun 11, 2024

Conversation

psolstice
Copy link
Contributor

@psolstice psolstice commented Jun 7, 2024 •
edited
Loading

PR intention

By design it's impossible to spend from spark to exchange address directly. Therefore, the user must go through transparent address if he wants to do so. This PR automates this process in Qt client and creates two transactions: the first one spending spark to transparent address and the second one sending newly created funds to exchange address(es).

Code changes brief

Changed Qt code handling "Send" page to support this scenario. Some slight modifications to core coin control functionality to force spending without creating extra vout for change (privacy reasons).

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits

Files that changed from the base of the PR and between cf19353 and 0f7a908.

Files selected for processing (5)
  • src/qt/sendcoinsdialog.cpp (8 hunks)
  • src/qt/walletmodel.cpp (1 hunks)
  • src/qt/walletmodel.h (1 hunks)
  • src/wallet/coincontrol.h (2 hunks)
  • src/wallet/wallet.cpp (1 hunks)
 _____________________________________________________________________________
< Easy things should be easy and hard things should be possible. - Larry Wall >
 -----------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

levonpetrosyan93
levonpetrosyan93 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenyap reubenyap merged commit 7ddce40 into master Jun 11, 2024
6 checks passed
@reubenyap reubenyap deleted the automate-private-spend branch June 11, 2024 07:12
@justanwar justanwar mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v0.14.13.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psolstice @levonpetrosyan93 @reubenyap